[Bug fix] Remove read-only constraint for management policy, and change properties types from integer to number by zfchen95 · Pull Request #6551 · Azure/azure-rest-api-specs

zfchen95 · 2019-07-03T22:55:07Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-07-03T22:55:09Z

SDK Automation [Logs] (Generated from 0e6f149, Iteration 6)

Python: Azure/azure-sdk-for-python [Logs] [Diff]

sdk/storage/azure-mgmt-storage [Logs] [Instructions]
- azure-mgmt-storage-4.0.0.zip
- azure_mgmt_storage-4.0.0-py2.py3-none-any.whl

Java: Azure/azure-sdk-for-java [Logs] [Diff]

storage/resource-manager/v2016_01_01 [Logs] [Instructions]
storage/resource-manager/v2017_10_01 [Logs] [Instructions]
storage/resource-manager/v2018_02_01 [Logs] [Instructions]
storage/resource-manager/v2018_03_01_preview [Logs] [Instructions]
storage/resource-manager/v2018_07_01 [Logs] [Instructions]
storage/resource-manager/v2019_04_01 [Logs] [Instructions]

Go: Azure/azure-sdk-for-go [Logs] [Diff]

preview/storage/mgmt/2015-05-01-preview [Logs] [Instructions]
- preview.storage.mgmt.2015-05-01-preview.zip
preview/storage/mgmt/2018-03-01-preview [Logs] [Instructions]
- preview.storage.mgmt.2018-03-01-preview.zip
storage/mgmt/2015-06-15 [Logs] [Instructions]
- storage.mgmt.2015-06-15.zip
storage/mgmt/2016-01-01 [Logs] [Instructions]
- storage.mgmt.2016-01-01.zip
storage/mgmt/2016-05-01 [Logs] [Instructions]
- storage.mgmt.2016-05-01.zip
storage/mgmt/2016-12-01 [Logs] [Instructions]
- storage.mgmt.2016-12-01.zip
storage/mgmt/2017-06-01 [Logs] [Instructions]
- storage.mgmt.2017-06-01.zip
storage/mgmt/2017-10-01 [Logs] [Instructions]
- storage.mgmt.2017-10-01.zip
storage/mgmt/2018-02-01 [Logs] [Instructions]
- storage.mgmt.2018-02-01.zip
storage/mgmt/2018-07-01 [Logs] [Instructions]
- storage.mgmt.2018-07-01.zip
storage/mgmt/2018-11-01 [Logs] [Instructions]
- storage.mgmt.2018-11-01.zip
storage/mgmt/2019-04-01 [Logs] [Instructions]
- storage.mgmt.2019-04-01.zip

JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]

@azure/arm-storage [Logs] [Instructions]
- azure-arm-storage-9.0.1.tgz

Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

azure_sdk [Logs] [Instructions]
- azure_sdk-0.28.0.gem
data/storage [Logs]

AutorestCI · 2019-07-03T22:57:04Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6382

AutorestCI · 2019-07-03T22:58:22Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3098

AutorestCI · 2019-07-03T22:59:52Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5270

azuresdkci · 2019-07-03T23:02:27Z

Can one of the admins verify this patch?

…onGreaterThan to float type

specification/storage/resource-manager/Microsoft.Storage/stable/2019-04-01/storage.json

nschonni · 2019-07-11T16:03:31Z

specification/storage/resource-manager/Microsoft.Storage/stable/2019-04-01/storage.json

-          "minimum": 0,
+          "type": "float",
+          "minimum": 0.0,
          "description": "Integer value indicating the age in days after last modification"


Description is still calling it an integer

In the server, the property is defined as float type for testing purpose. But in the real use case, we expect the input to be an integer-like number. I added a constraint in the update 0e6f149, which will only allow number that is the multiple of 1.

Yeah, but since it's no longer an actual int, the docs shouldn't call it that. Maybe just change "Integer value" to "Value"

Changed "Integer value" to "Value" 870609e

ryansbenson

Approved from ARMs side

Juliehzl · 2019-07-12T01:50:05Z

@myronfanqiu Please have a look at Ruby SDK.

Juliehzl · 2019-07-12T01:52:50Z

@zfchen95 Please have a look at checklist and try to fix the error in public.rest-api-specs.

mmyyrroonn · 2019-07-12T01:54:13Z

@myronfanqiu Please have a look at Ruby SDK.

It's a known issue in the SDK Automation. It doesn't block the real SDK generation process. Currently, we are working on it.

zfchen95 · 2019-07-12T04:14:25Z

@zfchen95 Please have a look at checklist and try to fix the error in public.rest-api-specs.

Hi @Juliehzl, I looked at the errors in public.rest-api-specs (model validation) test. None of them are caused by the change in this PR. Actually, all the errors are caused by "missing" schema in the storage swagger. I will try to fix them in another PR, not in this one because it will require an additional review..

message: >-
	Response statusCode "200" for operation "StorageAccounts_Failover" has
	response body provided in the example, however the response does not have a
	"schema" defined in the swagger spec.

https://dev.azure.com/azure-sdk/public/_build/results?buildId=66099&view=logs&j=8d2f9c49-cd83-5a9d-f3fe-2fd651afa742&t=43324f1f-6724-5d61-785f-f0ac9fd256a1&l=25

zfchen95 · 2019-07-12T21:13:26Z

@zfchen95 Please have a look at checklist and try to fix the error in public.rest-api-specs.

I have fixed the errors in #6611
If public.rest-api-specs pass is required, I could rebase this PR on another. Otherwise, it should be fine to merge..

Juliehzl · 2019-07-15T02:26:41Z

Yes. Please make changes in this PR.

zfchen95 · 2019-07-15T16:56:50Z

Yes. Please make changes in this PR.

Updated. All the checks pass.

zfchen95 · 2019-07-17T03:35:06Z

@Juliehzl Could you approve it?

[Bug fix] Remove read-only constraint for management policy

00d9e1b

azuresdkci assigned NelsonDaniel Jul 3, 2019

azuresdkci requested a review from NelsonDaniel July 3, 2019 22:56

AutorestCI mentioned this pull request Jul 3, 2019

[AutoPR storage/resource-manager] [Bug fix] Remove read-only constraint for management policy Azure/azure-sdk-for-python#6233

Merged

AutorestCI mentioned this pull request Jul 3, 2019

[AutoPR storage/resource-manager] [Bug fix] Remove read-only constraint for management policy Azure/azure-sdk-for-java#4277

Merged

AutorestCI mentioned this pull request Jul 3, 2019

[AutoPR storage/resource-manager] [Bug fix] Remove read-only constraint for management policy Azure/azure-sdk-for-go#5198

Merged

zfchen95 mentioned this pull request Jul 5, 2019

Storage ManagementPolicies reuses parameter definition with readonly flag from GET in PUT request #6549

Closed

[Bug fix] Change daysAfterCreationGreaterThan and daysAfterModificati…

de1ac16

…onGreaterThan to float type

zfchen95 changed the title ~~[Bug fix] Remove read-only constraint for management policy~~ [Bug fix] Remove read-only constraint for management policy, and change properties types to float Jul 5, 2019

NelsonDaniel added the Reassign label Jul 5, 2019

azuresdkci removed the Reassign label Jul 5, 2019

azuresdkci assigned Juliehzl and unassigned NelsonDaniel Jul 5, 2019

azuresdkci requested a review from Juliehzl July 5, 2019 20:26

Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 8, 2019

jhendrixMSFT reviewed Jul 11, 2019

View reviewed changes

specification/storage/resource-manager/Microsoft.Storage/stable/2019-04-01/storage.json Outdated Show resolved Hide resolved

nschonni reviewed Jul 11, 2019

View reviewed changes

change type to number

0e6f149

zfchen95 changed the title ~~[Bug fix] Remove read-only constraint for management policy, and change properties types to float~~ [Bug fix] Remove read-only constraint for management policy, and change properties types to number Jul 11, 2019

zfchen95 changed the title ~~[Bug fix] Remove read-only constraint for management policy, and change properties types to number~~ [Bug fix] Remove read-only constraint for management policy, and change properties types from integer to number Jul 11, 2019

ryansbenson approved these changes Jul 11, 2019

View reviewed changes

ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 11, 2019

Modify description, remove integer

870609e

Fix existing build errors in Storage swagger

ff223c3

Juliehzl approved these changes Jul 17, 2019

View reviewed changes

Juliehzl merged commit df89eaf into Azure:master Jul 17, 2019

Conversation

zfchen95 commented Jul 3, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Jul 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SDK Automation [Logs] (Generated from 0e6f149, Iteration 6)

Uh oh!

AutorestCI commented Jul 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Jul 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Jul 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Jul 3, 2019

Uh oh!

Uh oh!

nschonni Jul 11, 2019

Choose a reason for hiding this comment

Uh oh!

zfchen95 Jul 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nschonni Jul 11, 2019

Choose a reason for hiding this comment

Uh oh!

zfchen95 Jul 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryansbenson left a comment

Choose a reason for hiding this comment

Uh oh!

Juliehzl commented Jul 12, 2019

Uh oh!

Juliehzl commented Jul 12, 2019

Uh oh!

mmyyrroonn commented Jul 12, 2019

Uh oh!

zfchen95 commented Jul 12, 2019

Uh oh!

zfchen95 commented Jul 12, 2019

Uh oh!

Juliehzl commented Jul 15, 2019

Uh oh!

zfchen95 commented Jul 15, 2019

Uh oh!

zfchen95 commented Jul 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

openapi-sdkautomation bot commented Jul 3, 2019 •

edited

Loading

AutorestCI commented Jul 3, 2019 •

edited

Loading

AutorestCI commented Jul 3, 2019 •

edited

Loading

AutorestCI commented Jul 3, 2019 •

edited

Loading

zfchen95 Jul 11, 2019 •

edited

Loading

zfchen95 Jul 11, 2019 •

edited

Loading